Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-form-spinbutton (and components using it) have double detection of click #4838

Closed
Assignees
Labels
Status: Fixed / Implemented Issue fixed by a new release Type: Bug

Comments

@naletups
Copy link
Contributor

naletups commented Feb 26, 2020

Describe the bug

Steps to reproduce the bug

  1. Go to, e.g. https://deploy-preview-4783--bootstrap-vue.netlify.com/docs/components/form-spinbutton
  2. Click on smartphone browser on spin button
  3. In/decrements by two

Expected behavior

In/decrement by one

Versions

Libraries:

Netlify version of PR 4783

  • BootstrapVue: >2.5.0
  • Bootstrap: 4.4.*
  • Vue: 2.#.#

Environment:

  • Device: Android 9 smartphone
  • Browser: Chrome
  • Version: 80.0.3987.119

Demo link

https://deploy-preview-4783--bootstrap-vue.netlify.com/docs/components/form-spinbutton

Or time picker component

@tmorehouse
Copy link
Member

tmorehouse commented Feb 26, 2020

This could be because we are listening for both touchstart and mousedown events. Maybe we will need to add in detection of touchstart events and switch from mousedown if available, or only use mousedown events

@tmorehouse
Copy link
Member

tmorehouse commented Feb 26, 2020

I'll create a PR shortly that we can test out on on mobile. Just finishing up a call with work.

@naletups
Copy link
Contributor Author

naletups commented Feb 26, 2020

Thanks for your quick reply.

Holding one of the buttons for longer time makes it spin continuously in single increments (as intended).
It seems it's only the single touch/click. Double touch/click increments by four.

@tmorehouse
Copy link
Member

tmorehouse commented Feb 26, 2020

I might need to move the check for the "mouse already down" a bit higher

@tmorehouse
Copy link
Member

tmorehouse commented Feb 26, 2020

OK I found the issue... should hopefully have a solution later today

@tmorehouse
Copy link
Member

tmorehouse commented Feb 26, 2020

@naletups
Copy link
Contributor Author

naletups commented Feb 26, 2020

Yepp, works on my smartphone! Good job

@gabresende
Copy link

gabresende commented Mar 3, 2020

Hello
When will it go to production?

@tmorehouse
Copy link
Member

tmorehouse commented Mar 3, 2020

Hopefully tonight

@tmorehouse
Copy link
Member

tmorehouse commented Mar 5, 2020

BootstrapVue 2.6.0 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment