Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom b-calendar Icon #4851

Closed
cnelson-ma opened this issue Feb 27, 2020 · 4 comments
Closed

Custom b-calendar Icon #4851

cnelson-ma opened this issue Feb 27, 2020 · 4 comments
Labels
Status: Fixed / Implemented Issue fixed by a new release

Comments

@cnelson-ma
Copy link

Is your feature request related to a problem? Please describe...

I use FontAwesome in most of my projects, and being able to keep the icon set I use consistent in my project is important to its UX and Design.

Describe the solution you'd like

I think adding a slot for a custom icon would solve this problem. A prop on the element I think would be less flexable depending on the icon system someone is using.

Describe alternatives you've considered

Right now the only way I would be able to replace the icon is by hiding it via CSS then adding my own SVG icon in its place via CSS. Which seems hacky to me.

@tmorehouse
Copy link
Member

tmorehouse commented Feb 27, 2020

See PR #4795 and #4808

@cnelson-ma
Copy link
Author

cnelson-ma commented Feb 27, 2020

@tmorehouse Sorry if I am being dense, but I took a look at those PR's before submitting and there is nothing in them about icon customization options, just date formatting options.

Please let me know if I am missing that somewhere.

@tmorehouse
Copy link
Member

tmorehouse commented Feb 27, 2020

PR 4808 is the next release, and the second feature listed is custom button content for datepicker.

image

PR 4759 is the actual PR that introduces the slot for the datepicker button content.

image

@cnelson-ma
Copy link
Author

Wow definitely was being dense. My bad. Thanks.

@tmorehouse tmorehouse added the Status: Fixed / Implemented Issue fixed by a new release label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Fixed / Implemented Issue fixed by a new release
Projects
None yet
Development

No branches or pull requests

2 participants