Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timepicker is missing type declarations for the plugin #5035

Assignees
Projects

Comments

@stefanmo
Copy link

@stefanmo stefanmo commented Mar 29, 2020

Describe the bug

When importing the FormTimepickerPlugin typescript throws an error that bootstrap-vue has no exported member FormTimepickerPlugin

Steps to reproduce the bug

  1. Create a new vue project with typescript
  2. Import FormTimepickerPlugin and use it in Vue.
  3. Run project

Expected behavior

Typescript should not throw an error

Versions

Libraries:

  • BootstrapVue: 2.9.0
  • Bootstrap: 4.4.1
  • Vue: 2.6.11
  • typescript: 3.8.3

Environment:

  • Device: PC
  • OS: Linux

Demo link

Don't think it is necessary

Additional context

I can create a PR with the fix if desired.

@jacobmllr95 jacobmllr95 self-assigned this Mar 29, 2020
@jacobmllr95 jacobmllr95 added this to To do in 2.10.0 via automation Mar 29, 2020
2.10.0 automation moved this from To do to Done Mar 29, 2020
jacobmllr95 added a commit that referenced this issue Mar 29, 2020
…5035) (#5036)

* fix(types): add missing decleration for `b-form-timepicker`

* Fix title comment
@tmorehouse tmorehouse added the Status: Fixed / Implemented label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment