Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timepicker is missing type declarations for the plugin #5035

Closed
stefanmo opened this issue Mar 29, 2020 · 0 comments · Fixed by #5036, OpenTMI/opentmi-default-gui#60, tghelere/CL#25, mariazevedo88/hash-generator-js#46 or CodeForBaltimore/Healthcare-Rollcall#118
Closed

Timepicker is missing type declarations for the plugin #5035

stefanmo opened this issue Mar 29, 2020 · 0 comments · Fixed by #5036, OpenTMI/opentmi-default-gui#60, tghelere/CL#25, mariazevedo88/hash-generator-js#46 or CodeForBaltimore/Healthcare-Rollcall#118
Assignees
@jacobmllr95
Labels
Status: Confirmed Status: Fixed / Implemented Issue fixed by a new release Type: Bug

Comments

@stefanmo
Copy link

Describe the bug

When importing the FormTimepickerPlugin typescript throws an error that bootstrap-vue has no exported member FormTimepickerPlugin

Steps to reproduce the bug

  1. Create a new vue project with typescript
  2. Import FormTimepickerPlugin and use it in Vue.
  3. Run project

Expected behavior

Typescript should not throw an error

Versions

Libraries:

  • BootstrapVue: 2.9.0
  • Bootstrap: 4.4.1
  • Vue: 2.6.11
  • typescript: 3.8.3

Environment:

  • Device: PC
  • OS: Linux

Demo link

Don't think it is necessary

Additional context

I can create a PR with the fix if desired.
@jacobmllr95 jacobmllr95 self-assigned this Mar 29, 2020
@jacobmllr95 jacobmllr95 mentioned this issue Mar 29, 2020
Merged
20 tasks
jacobmllr95 added a commit that referenced this issue Mar 29, 2020
@jacobmllr95
fix(types): add missing declaration for b-form-timepicker (closes #…
ae84118 
…5035) (#5036)

* fix(types): add missing decleration for `b-form-timepicker`

* Fix title comment
@tmorehouse tmorehouse mentioned this issue Mar 31, 2020
Merged
This was referenced Apr 24, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 30, 2020
Open
Merged
@tmorehouse tmorehouse added the Status: Fixed / Implemented Issue fixed by a new release label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobmllr95 jacobmllr95

Labels
Status: Confirmed Status: Fixed / Implemented Issue fixed by a new release Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types): add missing declaration for b-form-timepicker (closes #5035) bootstrap-vue/bootstrap-vue
[Snyk] Upgrade bootstrap-vue from 2.9.0 to 2.10.0 OpenTMI/opentmi-default-gui
[Snyk] Upgrade bootstrap-vue from 2.9.0 to 2.10.0 tghelere/CL
[Snyk] Upgrade bootstrap-vue from 2.9.0 to 2.10.0 mariazevedo88/hash-generator-js
[Snyk] Upgrade bootstrap-vue from 2.9.0 to 2.10.0 CodeForBaltimore/Healthcare-Rollcall
[Snyk] Upgrade bootstrap-vue from 2.10.0 to 2.10.1 mariazevedo88/hash-generator-js
[Snyk] Upgrade bootstrap-vue from 2.10.0 to 2.10.1 OpenTMI/opentmi-default-gui
[Snyk] Upgrade bootstrap-vue from 2.10.0 to 2.10.1 tghelere/CL
[Snyk] Upgrade bootstrap-vue from 2.10.0 to 2.11.0 CodeForBaltimore/Healthcare-Rollcall
[Snyk] Upgrade bootstrap-vue from 2.0.0-rc.15 to 2.13.0 leonyork/cognito-oauth2-demo
3 participants
@jacobmllr95 @tmorehouse @stefanmo