Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

b-avatar button border size is too big when avatar size is set #5073

Closed
m-demydiuk opened this issue Apr 2, 2020 · 2 comments · Fixed by #5076, mariazevedo88/hash-generator-js#47, OpenTMI/opentmi-default-gui#62, tghelere/CL#26 or OpenTMI/opentmi-default-gui#64
Closed

b-avatar button border size is too big when avatar size is set #5073

m-demydiuk opened this issue Apr 2, 2020 · 2 comments · Fixed by #5076, mariazevedo88/hash-generator-js#47, OpenTMI/opentmi-default-gui#62, tghelere/CL#26 or OpenTMI/opentmi-default-gui#64
Labels
Status: Fixed / Implemented Issue fixed by a new release Status: Workaround Available Type: Bug Type: SCSS

Comments

@m-demydiuk
Copy link

Describe the bug

I have b-avatar button with size set to 150px
<b-avatar button @click="change" :src="currentUserImage" size="150px"></b-avatar>

And it looks tooo odd:
image

Why avatar border is increased?

BTW, when avatar is in normal mode (not button), it looks ok:
image
@tmorehouse
Copy link
Member

tmorehouse commented Apr 2, 2020 •
edited
Loading

Ah, we'll need to override the button padding. For now you can do this to remove hte padding from the button:

<b-avatar button @click="change" :src="currentUserImage" size="150px" class="p-0"></b-avatar>

tmorehouse added a commit that referenced this issue Apr 2, 2020
@tmorehouse
fix(b-avatar): remove default padding when in button mode (fixes #5073)
5f66db0
This was referenced Apr 2, 2020
Merged
Merged
tmorehouse added a commit that referenced this issue Apr 2, 2020
@tmorehouse
fix(b-avatar): remove default padding when in button mode (fixes #5073)…
26377b3 
… (#5076)
@tmorehouse
Copy link
Member

@m-demydiuk BootstrapVue v2.10.1 has been released with the fix.

This was referenced Apr 25, 2020
Merged
Merged
Merged
This was referenced Apr 30, 2020
Merged
Merged
Open
Merged
Merged
@tmorehouse tmorehouse added the Status: Fixed / Implemented Issue fixed by a new release label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Fixed / Implemented Issue fixed by a new release Status: Workaround Available Type: Bug Type: SCSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(b-avatar): remove default padding when in button mode (fixes #5073) bootstrap-vue/bootstrap-vue
[Snyk] Upgrade bootstrap-vue from 2.10.0 to 2.10.1 mariazevedo88/hash-generator-js
[Snyk] Upgrade bootstrap-vue from 2.10.0 to 2.10.1 OpenTMI/opentmi-default-gui
[Snyk] Upgrade bootstrap-vue from 2.10.0 to 2.10.1 tghelere/CL
[Snyk] Upgrade bootstrap-vue from 2.10.1 to 2.11.0 OpenTMI/opentmi-default-gui
[Snyk] Upgrade bootstrap-vue from 2.10.1 to 2.11.0 tghelere/CL
[Snyk] Upgrade bootstrap-vue from 2.10.0 to 2.11.0 CodeForBaltimore/Healthcare-Rollcall
[Snyk] Upgrade bootstrap-vue from 2.10.1 to 2.11.0 mariazevedo88/hash-generator-js
[Snyk] Upgrade bootstrap-vue from 2.0.0-rc.15 to 2.13.0 leonyork/cognito-oauth2-demo
2 participants
@tmorehouse @m-demydiuk