Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datepicker and timepicker in button only mode: horizontal padding missing #5251

Closed
shimikano opened this issue Apr 24, 2020 · 2 comments · Fixed by #5252 · May be fixed by leonyork/cognito-oauth2-demo#1
Closed

datepicker and timepicker in button only mode: horizontal padding missing #5251

shimikano opened this issue Apr 24, 2020 · 2 comments · Fixed by #5252 · May be fixed by leonyork/cognito-oauth2-demo#1
Assignees
@tmorehouse
Labels
Status: Fixed / Implemented Issue fixed by a new release Type: Bug Type: SCSS

Comments

@shimikano
Copy link

Describe the bug

b-form-datepicker and b-form-timepicker in 'button only' mode seem to lack horizontal padding. The issue is present in the official documentation (https://bootstrap-vue.org/docs/components/form-datepicker#button-only-mode):

screenshot_11

Expected behavior

The padding should match the non 'button only' mode.

Versions

Libraries:

  • BootstrapVue: 2.12.0
  • Bootstrap: 4.4.1
  • Vue: 2.6.22
@tmorehouse
Copy link
Member

tmorehouse commented Apr 24, 2020 •
edited
Loading

Ah, this might be because of the changes made to not use Bootstrap Utility classes within the innards of the component...

@tmorehouse tmorehouse self-assigned this Apr 24, 2020
@tmorehouse
Copy link
Member

tmorehouse commented Apr 24, 2020 •
edited
Loading

You can get around this issue by setting the prop menu-class to 'p-2' or 'p-3'

tmorehouse added a commit that referenced this issue Apr 24, 2020
@tmorehouse
fix(b-form-date-picker, b-form-timepicker): fix menu padding in butto…
8e1e15e 
…n only mode (fixes #5251)
This was referenced Apr 24, 2020
Merged
Merged
tmorehouse added a commit that referenced this issue Apr 26, 2020
@tmorehouse
fix(b-form-datepicker, b-form-timepicker): fix menu padding in button…
d57a643 
… only mode (fixes #5251) (#5252)
@snyk-bot snyk-bot mentioned this issue Apr 30, 2020
Open
@tmorehouse tmorehouse added the Status: Fixed / Implemented Issue fixed by a new release label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmorehouse tmorehouse

Labels
Status: Fixed / Implemented Issue fixed by a new release Type: Bug Type: SCSS
Projects
None yet
Milestone
No milestone
2 participants
@tmorehouse @shimikano