Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow calendar navigation button variant styling #5702

Closed
darrinmn9 opened this issue Aug 26, 2020 · 1 comment · Fixed by #5705
Closed

allow calendar navigation button variant styling #5702

darrinmn9 opened this issue Aug 26, 2020 · 1 comment · Fixed by #5705

Comments

@darrinmn9
Copy link

darrinmn9 commented Aug 26, 2020

Is your feature request related to a problem? Please describe...

It seems that b-calendar does not support the styling of the date navigation buttons, and always applies "outline-secondary" to the button styling. Normally this isn't an issue, but when using b-calendar with date navigation button slots, I'd like to have the ability to change the button variant instead of it being forced to "outline-secondary".

In the screenshot below:

my custom theme uses primary - blue, secondary - orange
I added custom svgs for the date navigation button slots that match the primary variant. This creates an undesired orange background color on hover. I can't find any way to change this via current props of b-calendar.

calendar_date_buttons

Describe the solution you'd like

Add a prop to control the date navigation button variant nav-button-variant (default to "outline-secondary" so that this feature can be added in a non-breaking way)

@darrinmn9
Copy link
Author

darrinmn9 commented Aug 28, 2020

ty for such a quick PR @Hiws

@jacobmllr95 jacobmllr95 added this to To do in v2.17.0 via automation Aug 31, 2020
v2.17.0 automation moved this from To do to Done Sep 1, 2020
jacobmllr95 added a commit that referenced this issue Sep 1, 2020
* init

* update package.json

* Improve `navButtonVariant` prop handling

Co-authored-by: Jacob Müller <jacob.mueller.elz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2.17.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants