New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[form-select] `text-field` property doesn't work when the values is an object #622

Closed
hydraheim opened this Issue Jul 3, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@hydraheim
Contributor

hydraheim commented Jul 3, 2017

Here's a fiddle: https://jsfiddle.net/7m4oa0ed/3/

In short, the "text-field" property is not picked up, but the "value-field" works (as you can see if you inspect the select.

Docs reference: https://bootstrap-vue.js.org/docs/components/form-select

@hydraheim hydraheim changed the title from `text-field` property doesn't work when the values is an object to [form-select] `text-field` property doesn't work when the values is an object Jul 3, 2017

@tmorehouse tmorehouse added the Type: Bug label Jul 3, 2017

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 3, 2017

I think I see the issue.

You are using the object format for specifying your options, rather than a plain array of objects. I think the component code is missing the checks when this type of object is encountered.

tmorehouse added a commit that referenced this issue Jul 3, 2017

@tmorehouse tmorehouse added this to the v0.18.0 milestone Jul 3, 2017

pi0 added a commit that referenced this issue Jul 3, 2017

@tmorehouse tmorehouse modified the milestone: v0.18.0 Jul 4, 2017

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 4, 2017

@hydraheim this fix PR has been merged into master and should be available in the next release (v0.18.0) coming soon.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 5, 2017

@hydraheim

Release v0.18..0 is now available (latest), and this issue should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment