Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b-form-group feedback feedback aria attributes redundant #6300

Closed
tinynow opened this issue Jan 8, 2021 · 0 comments · Fixed by #6346
Closed

b-form-group feedback feedback aria attributes redundant #6300

tinynow opened this issue Jan 8, 2021 · 0 comments · Fixed by #6346

Comments

@tinynow
Copy link

tinynow commented Jan 8, 2021

Describe the bug

The HTML for the feedback messages redundantly uses role="alert", aria-live="assertive" and aria-atomic="true"
Elements with the role alert have an implicit aria-live value of assertive, and an implicit aria-atomic value of true.
https://www.w3.org/TR/wai-aria-1.1/#alert

I think this also makes using aria-live="polite" irrelevant.

Steps to reproduce the bug

  1. Go to https://bootstrap-vue.org/docs/components/form-group
  2. Trigger the feedback messages in the demo component
  3. Inspect the rendered markup

Versions

Libraries:

  • BootstrapVue: 2.21.2

Demo link

https://bootstrap-vue.org/docs/components/form-group

Additional context

I have not validated that this is an issue with assistive technology, only with the aria specifications.

@jacobmllr95 jacobmllr95 added this to To do in v2.22.0 via automation Jan 8, 2021
@jacobmllr95 jacobmllr95 moved this from To do to In progress in v2.22.0 Jan 27, 2021
v2.22.0 automation moved this from In progress to Done Feb 2, 2021
jacobmllr95 added a commit that referenced this issue Feb 2, 2021
…loses #6300, #6307) (#6346)

* fix(b-form-group): remove `role="alert"` from valid/invalid feedback

* Update form-group.spec.js

Co-authored-by: Hiws <hiws@live.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2.22.0
  
Done
2 participants