Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b-form-group feedback text should be inserted (rather than toggling display) #6307

Closed
tinynow opened this issue Jan 10, 2021 · 0 comments · Fixed by #6346
Closed

b-form-group feedback text should be inserted (rather than toggling display) #6307

tinynow opened this issue Jan 10, 2021 · 0 comments · Fixed by #6346

Comments

@tinynow
Copy link

tinynow commented Jan 10, 2021

Describe the bug

Best practices for assistive technology suggest inserting contents of a live region that is not hidden via display: none;, or at least putting the aria-live or alert role on a parent and toggling the visibility of children.
https://www.davidmacd.com/blog/test-aria-live-display-none.html

Steps to reproduce the bug

Versions

Libraries:

  • BootstrapVue: 2.21.2

Additional context

#6300 Addresses a related issue with redundant aria. It seems like removing the role: alert and going with the aria-live solution is the recommendation: https://www.w3.org/WAI/tutorials/forms/notifications/#inline
As with that issue, I am not basing this on testing, only research of the specs and the testing article above.

@jacobmllr95 jacobmllr95 added this to To do in v2.22.0 via automation Jan 11, 2021
@tinynow tinynow changed the title b-form-group feedback should be text should be inserted (rather than toggling display) b-form-group feedback text should be inserted (rather than toggling display) Jan 14, 2021
@jacobmllr95 jacobmllr95 moved this from To do to In progress in v2.22.0 Jan 27, 2021
v2.22.0 automation moved this from In progress to Done Feb 2, 2021
jacobmllr95 added a commit that referenced this issue Feb 2, 2021
…loses #6300, #6307) (#6346)

* fix(b-form-group): remove `role="alert"` from valid/invalid feedback

* Update form-group.spec.js

Co-authored-by: Hiws <hiws@live.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2.22.0
  
Done
2 participants