New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCarousel infinite loop #764

Closed
Ruplahlava opened this Issue Aug 2, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@Ruplahlava

Ruplahlava commented Aug 2, 2017

Hello,
one small thing - when i click carousel control arrows quickly, im getting this warning from vue (in development):

You may have an infinite update loop in watcher with expression "index"
found in

---> <BCarousel>
<TransitionGroup>
...

When you do that in production build, whole tab freezes (chrome,ff)
Tried that in your example carousel in documentation and it did the same thing...

@Ruplahlava Ruplahlava changed the title from BCarousel to BCarousel infinite loop Aug 2, 2017

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Aug 2, 2017

Yeah, the <b-carousel> component is a bit buggy (hence why we have labeled it as unstable).

I've noticed the same issues in chrome with the tab freezing when controls are clicked in quick succession.

Carousel needs an overhaul for sure.

@tmorehouse tmorehouse added the Type: Bug label Aug 2, 2017

tmorehouse added a commit that referenced this issue Aug 2, 2017

fix(carousel): Prevent going to slide if transitioning
Prevents index from being updated if current slide is transitioning.

Specifically when control is clicked in quick succession (possible fix for issue #764)

tmorehouse added a commit that referenced this issue Aug 3, 2017

fix(carousel): Prevent going to slide if transitioning (issue #764) (#…
…765)

Prevents index from being updated if current slide is transitioning.

Specifically when control is clicked in quick succession (possible fix for issue #764)
@Ruplahlava

This comment has been minimized.

Ruplahlava commented Aug 12, 2017

Thank you for the quick fix! :)

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Aug 12, 2017

Carousel should be quite stable now. It has one minor bug which prevents it from cycling to the first slide when it reaches that last slide, but that should be fixed shortly (it is available in the new dev branch).

@tmorehouse tmorehouse closed this Aug 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment