New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scrollspy): Handle nested nav-links when inside nav-item #1068

Merged
merged 3 commits into from Sep 16, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Sep 16, 2017

When using the nav-link inside a nav-item markup style, scrollspy wasnt automatically applying the .active class to parent previous sibling child.

This is also a bug in the official Bootstrap V4 dev code.

@tmorehouse tmorehouse added this to the v1.0.0 milestone Sep 16, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Sep 16, 2017

Codecov Report

Merging #1068 into dev will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #1068      +/-   ##
=========================================
- Coverage   36.5%   36.48%   -0.03%     
=========================================
  Files        109      109              
  Lines       3249     3251       +2     
  Branches     947      948       +1     
=========================================
  Hits        1186     1186              
- Misses      1724     1725       +1     
- Partials     339      340       +1
Impacted Files Coverage Δ
lib/classes/scrollspy.js 4.34% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4e33f...e363d32. Read the comment docs.

@tmorehouse tmorehouse merged commit f4e017c into dev Sep 16, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the scrollspy/nested branch Sep 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment