New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(pagination): Move common code to pagination mixin #1069

Merged
merged 6 commits into from Sep 16, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Sep 16, 2017

Moves common code used in <b-pagination> and <b-pagination-nav> into a mixin

tmorehouse added some commits Sep 16, 2017

@tmorehouse tmorehouse added this to the v1.0.0 milestone Sep 16, 2017

@tmorehouse tmorehouse requested review from pi0 and alexsasharegan Sep 16, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Sep 16, 2017

Codecov Report

Merging #1069 into dev will increase coverage by 0.95%.
The diff coverage is 37.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1069      +/-   ##
==========================================
+ Coverage   36.48%   37.44%   +0.95%     
==========================================
  Files         109      110       +1     
  Lines        3251     3157      -94     
  Branches      948      920      -28     
==========================================
- Hits         1186     1182       -4     
+ Misses       1725     1623     -102     
- Partials      340      352      +12
Impacted Files Coverage Δ
lib/components/pagination-nav.vue 37.5% <ø> (+25.73%) ⬆️
lib/components/pagination.vue 34.48% <100%> (-1.12%) ⬇️
lib/mixins/pagination.js 36.58% <36.58%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c267afa...141ca3f. Read the comment docs.

@tmorehouse tmorehouse merged commit 0d41e83 into dev Sep 16, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the pagination/mixin branch Sep 16, 2017

@tmorehouse tmorehouse changed the title from feat(pagination): Move common code to pagination mixin to perf(pagination): Move common code to pagination mixin Sep 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment