New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): Allow fields to be an array of objects #1075

Merged
merged 10 commits into from Sep 18, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Sep 18, 2017

While most browsers store object keys in the order they were defined, this is not always guaranteed.

This change allows fields to be passed as an array of field objects, to ensure desired field order.

featt(table): Allow fields to be an array of objects
While most browsers store object keys in the order they were defined, this is not always guaranteed.

This change allows fields to be passed as an array of field objects, to ensure desired field order.
@codecov-io

This comment has been minimized.

codecov-io commented Sep 18, 2017

Codecov Report

Merging #1075 into dev will increase coverage by 0.26%.
The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1075      +/-   ##
==========================================
+ Coverage   37.38%   37.64%   +0.26%     
==========================================
  Files         110      110              
  Lines        3162     3182      +20     
  Branches      922      927       +5     
==========================================
+ Hits         1182     1198      +16     
- Misses       1628     1632       +4     
  Partials      352      352
Impacted Files Coverage Δ
lib/components/table.vue 67.72% <68.42%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d008dcf...252e617. Read the comment docs.

tmorehouse added some commits Sep 18, 2017

@tmorehouse tmorehouse changed the title from [WIP] feat(table): Allow fields to be an array of objects to feat(table): Allow fields to be an array of objects Sep 18, 2017

@tmorehouse tmorehouse removed the Status: WIP label Sep 18, 2017

@tmorehouse tmorehouse merged commit e2f90ff into dev Sep 18, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the table/enhancements branch Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment