New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): New fixed prop, allow disable localSort, emit context-changed event, and style tweaks #1076

Merged
merged 6 commits into from Sep 18, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Sep 18, 2017

Adds new prop fixed to render table with equal fixed-width columns.

Adds new prop no-local-sorting to disabled local sorting (useful when items is an array and user wants to sort externally)

Emits event contenxt-changed with ctx object as arg whenever the context of the table changes

Slight adjustments to styling for better sort indicator alignment

tmorehouse added some commits Sep 18, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Sep 18, 2017

Codecov Report

Merging #1076 into dev will increase coverage by 0.51%.
The diff coverage is 69.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1076      +/-   ##
==========================================
+ Coverage   37.64%   38.15%   +0.51%     
==========================================
  Files         110      110              
  Lines        3182     3184       +2     
  Branches      927      929       +2     
==========================================
+ Hits         1198     1215      +17     
+ Misses       1632     1620      -12     
+ Partials      352      349       -3
Impacted Files Coverage Δ
lib/components/table.vue 70.72% <69.56%> (+2.99%) ⬆️
lib/utils/loose-equal.js 76.19% <0%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f90ff...2a4d2f0. Read the comment docs.

tmorehouse added some commits Sep 18, 2017

@tmorehouse tmorehouse merged commit 4447c7c into dev Sep 18, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the table/feat branch Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment