New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooltip+popover): Eight new placement options #1081

Merged
merged 11 commits into from Sep 20, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Sep 20, 2017

Besides the usual left, right, top and bottom, the following 8 new placements are now available:

topleft, topright, bottomleft, bottomright, lefttop, leftbottom, righttop and rightbottom

Supported in both directive and component versions.

Aligns with the new proposed placements in Bootstrap V4.beta.2

@codecov-io

This comment has been minimized.

codecov-io commented Sep 20, 2017

Codecov Report

Merging #1081 into dev will decrease coverage by 0.08%.
The diff coverage is 7.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1081      +/-   ##
==========================================
- Coverage   38.12%   38.03%   -0.09%     
==========================================
  Files         110      110              
  Lines        3187     3197      +10     
  Branches      930      932       +2     
==========================================
+ Hits         1215     1216       +1     
- Misses       1622     1629       +7     
- Partials      350      352       +2
Impacted Files Coverage Δ
lib/mixins/toolpop.js 2.98% <ø> (ø) ⬆️
lib/directives/tooltip.js 4.83% <0%> (ø) ⬆️
lib/directives/popover.js 4.83% <0%> (ø) ⬆️
lib/classes/tooltip.js 4.59% <8.33%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3489d0...3660d5d. Read the comment docs.

tmorehouse added some commits Sep 20, 2017

@tmorehouse tmorehouse merged commit dae7855 into dev Sep 20, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the toolpop branch Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment