New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooltip popover): Don't close if focus moves between trigger element and tip/popover #1093

Merged
merged 2 commits into from Sep 22, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Sep 22, 2017

Only applies when the trigger is set to focus and/or blur

Handy when using interactive popover content

feat(tooltip popover): If focus moves betwen trigger element to tip/p…
…opover, don't close

Only applies when the trigger(s) are set to `focus` and/or `blur`

@tmorehouse tmorehouse added this to the v1.0.0 milestone Sep 22, 2017

@tmorehouse tmorehouse changed the title from feat(tooltip popover): Don't close if focus moves betwen trigger element to tip/popover to feat(tooltip popover): Don't close if focus moves betwen trigger element and tip/popover Sep 22, 2017

@tmorehouse tmorehouse changed the title from feat(tooltip popover): Don't close if focus moves betwen trigger element and tip/popover to feat(tooltip popover): Don't close if focus moves between trigger element and tip/popover Sep 22, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Sep 22, 2017

Codecov Report

Merging #1093 into dev will decrease coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #1093      +/-   ##
=========================================
- Coverage   33.26%   33.1%   -0.17%     
=========================================
  Files         109     109              
  Lines        2850    2864      +14     
  Branches      884     888       +4     
=========================================
  Hits          948     948              
- Misses       1531    1541      +10     
- Partials      371     375       +4
Impacted Files Coverage Δ
lib/classes/tooltip.js 4.41% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51db684...4fe2fe6. Read the comment docs.

@tmorehouse tmorehouse merged commit 87ffb4f into dev Sep 22, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tip/focus branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment