New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-options): Handle object special cases #1099

Merged
merged 1 commit into from Sep 23, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Sep 23, 2017

Handle case where object format is missing value and/or text keys.

Addresses issue #1098

fix(form-options): Handle object special cases
Handle case where object format is missing value and/or text keys

@tmorehouse tmorehouse added this to the v1.0.0 milestone Sep 23, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Sep 23, 2017

Codecov Report

Merging #1099 into dev will increase coverage by 0.08%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #1099      +/-   ##
=========================================
+ Coverage   33.1%   33.18%   +0.08%     
=========================================
  Files        109      109              
  Lines       2864     2866       +2     
  Branches     888      890       +2     
=========================================
+ Hits         948      951       +3     
- Misses      1541     1542       +1     
+ Partials     375      373       -2
Impacted Files Coverage Δ
lib/mixins/form-options.js 50% <42.85%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e0750...1d82d68. Read the comment docs.

@tmorehouse tmorehouse merged commit 1b17df3 into dev Sep 23, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the fix/form-options branch Sep 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment