New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): Don't ovrwrite user supplied tabindex if not disabled #1120

Merged
merged 3 commits into from Sep 27, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Sep 27, 2017

A user supplied tabindex attribut on b-button was being overwritten as null

This fix preserves the users original tabindex when not disabled

Addresses issue #1119

fix(button): Don't ovrwrite user supplied tabindex if not disabled
A user supplied `tabindex` to b-button was being overwritten as `null`

This fix preserves the users original tabindex when not disabled

Addresses issue #1119

@tmorehouse tmorehouse added this to the v1.0.0 milestone Sep 27, 2017

@tmorehouse tmorehouse requested a review from alexsasharegan Sep 27, 2017

tmorehouse added some commits Sep 27, 2017

@tmorehouse tmorehouse merged commit 18f5129 into dev Sep 27, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the issue/1119 branch Sep 27, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Sep 27, 2017

Codecov Report

Merging #1120 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1120   +/-   ##
=======================================
  Coverage   33.18%   33.18%           
=======================================
  Files         109      109           
  Lines        2866     2866           
  Branches      890      890           
=======================================
  Hits          951      951           
  Misses       1542     1542           
  Partials      373      373
Impacted Files Coverage Δ
lib/components/button.js 73.07% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc46ef9...388a910. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment