New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: In toggleClasses we expect strings instead of undefined variables. #1123

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
3 participants
@amir-hadi
Contributor

amir-hadi commented Sep 28, 2017

I couldn't use disabled on b-nav-item-dropdown, because it breaks in toggleClasses computed property. This should fix it. I tested locally using the Playground and it works.

Thanks for this great project!

Amir

@codecov-io

This comment has been minimized.

codecov-io commented Sep 28, 2017

Codecov Report

Merging #1123 into dev will increase coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #1123     +/-   ##
=========================================
+ Coverage   33.18%   33.39%   +0.2%     
=========================================
  Files         109      109             
  Lines        2866     2866             
  Branches      890      890             
=========================================
+ Hits          951      957      +6     
+ Misses       1542     1536      -6     
  Partials      373      373
Impacted Files Coverage Δ
lib/components/nav-item-dropdown.vue 0% <0%> (ø) ⬆️
lib/components/form-input.vue 42.85% <0%> (+3.57%) ⬆️
lib/components/button.js 76.92% <0%> (+3.84%) ⬆️
lib/components/form-group.vue 76.19% <0%> (+4.76%) ⬆️
lib/components/embed.js 100% <0%> (+33.33%) ⬆️
lib/components/button-group.js 100% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf3a52...909bdbb. Read the comment docs.

@tmorehouse tmorehouse merged commit aabc54d into bootstrap-vue:dev Sep 28, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment