New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooltip+popover): Allow delay to be object in component versions #1131

Merged
merged 3 commits into from Sep 28, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Sep 28, 2017

The delay prop now optionally accepts an object in the form { show: 123, hide: 123} to specify the show and hide delays individually.

Addresses issue #1130

@codecov-io

This comment has been minimized.

codecov-io commented Sep 28, 2017

Codecov Report

Merging #1131 into dev will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1131      +/-   ##
==========================================
- Coverage   33.18%   33.17%   -0.02%     
==========================================
  Files         109      109              
  Lines        2866     2867       +1     
  Branches      890      891       +1     
==========================================
  Hits          951      951              
  Misses       1542     1542              
- Partials      373      374       +1
Impacted Files Coverage Δ
lib/mixins/toolpop.js 2.94% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aabc54d...748e2d0. Read the comment docs.

tmorehouse added some commits Sep 28, 2017

@tmorehouse tmorehouse merged commit 1a47c87 into dev Sep 28, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the toolpop/delay branch Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment