New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): Ensure body scrollbar is removed if modal destroyed before being closed #1168

Merged
merged 4 commits into from Oct 7, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Oct 6, 2017

Use case: If a modal is open on a child route and the route is changed, the modal is closed (destroyed), but body scrollbar and navbar/fixed content adjustments (margins/padding) were not being removed.

Note this PR does not address similar issues when modal is inside a <keep-alive> component.

Addresses issue #1167

tmorehouse added some commits Oct 6, 2017

fix(modal): Ensure body scrollbar is removed if modal destroyed befor…
…e being closed

Use case: If a modal is open on a child route and the route is changed, the modal is closed, but body scrollbar and navbar/fixed content adjustments (margins/padding) were not being removed.

Note this PR does not address similar issues when modal is inside a `<keep-alive>` component.
@codecov-io

This comment has been minimized.

codecov-io commented Oct 6, 2017

Codecov Report

Merging #1168 into dev will decrease coverage by 0.06%.
The diff coverage is 10%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1168      +/-   ##
==========================================
- Coverage   32.94%   32.87%   -0.07%     
==========================================
  Files         109      109              
  Lines        2853     2865      +12     
  Branches      886      891       +5     
==========================================
+ Hits          940      942       +2     
- Misses       1537     1546       +9     
- Partials      376      377       +1
Impacted Files Coverage Δ
lib/components/modal.vue 1.13% <0%> (-0.05%) ⬇️
lib/utils/dom.js 47.54% <40%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef0ecc...0f95b31. Read the comment docs.

@tmorehouse tmorehouse merged commit e0a4444 into dev Oct 7, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the modal/destroy branch Oct 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment