New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): Modal jumps when dialog height changes #1182

Merged
merged 1 commit into from Oct 9, 2017

Conversation

Projects
None yet
4 participants
@DabeDotCom
Contributor

DabeDotCom commented Oct 9, 2017

Building on #1058... If the modal dialog's content height changed (e.g., "v-if" conditionally displayed an error message), the padding-right could be applied inconsistently.

twbs/bootstrap#23672 fixed this by calling this.adjustDialog() during onBeforeEnter(), as well

fix(modal): Modal jumps when dialog height changes
Building on #1058...  If the modal dialog's content height
changed (e.g., "v-if" conditionally displayed an error message),
the `padding-right` could be applied inconsistently.

twbs/bootstrap#23672 fixed this by calling `this.adjustDialog()`
during `onBeforeEnter()`, as well
@codecov-io

This comment has been minimized.

codecov-io commented Oct 9, 2017

Codecov Report

Merging #1182 into dev will increase coverage by 0.19%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1182      +/-   ##
==========================================
+ Coverage   32.87%   33.07%   +0.19%     
==========================================
  Files         109      109              
  Lines        2865     2866       +1     
  Branches      891      891              
==========================================
+ Hits          942      948       +6     
+ Misses       1546     1541       -5     
  Partials      377      377
Impacted Files Coverage Δ
lib/components/modal.vue 1.12% <0%> (-0.01%) ⬇️
lib/components/form-input.vue 42.85% <0%> (+3.57%) ⬆️
lib/components/button.js 76.92% <0%> (+3.84%) ⬆️
lib/components/form-group.vue 76.66% <0%> (+6.66%) ⬆️
lib/components/button-group.js 100% <0%> (+33.33%) ⬆️
lib/components/embed.js 100% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b11ca85...47d0ef3. Read the comment docs.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Oct 9, 2017

The DOM observer should catch most changes in modal content (i.e. sections being conditionally hidden/shown), although this observation only occurs after the modal has opened (and not to mention that internet explorer sucks when it comes to DOM observation).

But this is a good addition. Thanks!

@tmorehouse tmorehouse merged commit 126fe95 into bootstrap-vue:dev Oct 9, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment