New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Progress): Bootstrap V4.beta.2 CSS height prop change #1217

Merged
merged 3 commits into from Oct 21, 2017

Conversation

Projects
None yet
3 participants
@mosinve
Member

mosinve commented Oct 21, 2017

Move height prop from progress-bar to progress according to current Bootstrap4-beta2.
fixes #1216

fix(Progress) height prop
Move height prop from progress-bar to progress according to current Bootstrap4-beta2.
fixes #1216

@mosinve mosinve requested a review from tmorehouse Oct 21, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Oct 21, 2017

Codecov Report

Merging #1217 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1217      +/-   ##
==========================================
+ Coverage   32.86%   32.87%   +0.01%     
==========================================
  Files         109      109              
  Lines        2866     2865       -1     
  Branches      920      890      -30     
==========================================
  Hits          942      942              
+ Misses       1547     1546       -1     
  Partials      377      377
Impacted Files Coverage Δ
lib/components/progress-bar.vue 0% <ø> (ø) ⬆️
lib/components/progress.vue 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3916c...a80d3c7. Read the comment docs.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Oct 21, 2017

Will need to adjust b-progress-bar as it also sets it's own height based on parent b-progress height value.

Basically just need to remove it as new CSS sets height === 100% on the progress-bar

@tmorehouse tmorehouse changed the title from fix(Progress) height prop to fix(Progress): Bootstrap V4.beta.2 CSS height prop change Oct 21, 2017

mosinve and others added some commits Oct 21, 2017

@tmorehouse tmorehouse referenced this pull request Oct 21, 2017

Closed

[Informational] Bootstrap V4.beta 1, 2 & 3 ship list #747

45 of 56 tasks complete

@tmorehouse tmorehouse merged commit a963ea3 into dev Oct 21, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the mosinve-patch-1 branch Oct 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment