New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-select): Custom select now supports multiple attribute in V4.beta.2 CSS #1223

Merged
merged 2 commits into from Oct 23, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Oct 22, 2017

Bootstrap V4.beta.2 now supports custom select styling on selects with the multiple attribute set.

Addresses issue #747

fix(form-select): Custom select now supports multiple attribute in V4…
….beta.2 CSS

Bootstrap V4.beta.2 now supports custom select styling on selects with the `multiple` attribute set.

@tmorehouse tmorehouse changed the title from fix(form-select): Custom select now supports multiple attribute in V4… to fix(form-select): Custom select now supports multiple attribute in V4.beta.2 CSS Oct 22, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Oct 22, 2017

Codecov Report

Merging #1223 into dev will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1223   +/-   ##
=======================================
  Coverage   32.91%   32.91%           
=======================================
  Files         109      109           
  Lines        2865     2865           
  Branches      890      890           
=======================================
  Hits          943      943           
  Misses       1546     1546           
  Partials      376      376
Impacted Files Coverage Δ
lib/components/form-select.vue 77.77% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6568005...443455b. Read the comment docs.

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Oct 22, 2017

@tmorehouse tmorehouse referenced this pull request Oct 22, 2017

Closed

[Informational] Bootstrap V4.beta 1, 2 & 3 ship list #747

45 of 56 tasks complete

@tmorehouse tmorehouse removed the Status: WIP label Oct 22, 2017

@pi0

pi0 approved these changes Oct 23, 2017

@tmorehouse tmorehouse merged commit 3a4262d into dev Oct 23, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the form-select/v4beta2 branch Oct 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment