New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(navbar-nav): New b-navbar-nav component #1231

Merged
merged 10 commits into from Oct 24, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Oct 23, 2017

The class 'nav' is no longer used in BS V4.beta.2 when the nav is a navbar-nav.

Introduce a new lightweight functional <b-navbar-nav> component.

Deprecate is-nav-bar prop on <b-nav>

fix(nav): when 'is-nav-ba'r set, do not apply the 'nav' class
The class 'nav' is no longer used in BS V4.beta.2 when the nav is a navbar-nav.

@tmorehouse tmorehouse added this to the v1.0.0 milestone Oct 23, 2017

@tmorehouse tmorehouse requested a review from alexsasharegan Oct 23, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Oct 23, 2017

Codecov Report

Merging #1231 into dev will decrease coverage by 0.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #1231      +/-   ##
=========================================
- Coverage   33.02%     33%   -0.02%     
=========================================
  Files         109     110       +1     
  Lines        2877    2881       +4     
  Branches      895     925      +30     
=========================================
+ Hits          950     951       +1     
- Misses       1548    1550       +2     
- Partials      379     380       +1
Impacted Files Coverage Δ
lib/components/nav.js 25% <0%> (-25%) ⬇️
lib/components/navbar-nav.js 50% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9427e64...1ec82af. Read the comment docs.

tmorehouse added some commits Oct 23, 2017

Create navbar-nav.js
Dedicated `b-navbar-nav` functional component, with less weight than the `b-nav`

@tmorehouse tmorehouse changed the title from fix(nav): when 'is-nav-ba'r set, do not apply the 'nav' class to feat(navbar-nav): New b-navbar-nav component Oct 23, 2017

@tmorehouse tmorehouse requested review from pi0 and mosinve Oct 23, 2017

mosinve added some commits Oct 24, 2017

@@ -3,11 +3,11 @@
"component": "bNavbar",
"components": [
"bNavbarNav",
"bNavbarBrand"
"bNavbarBrand",

This comment has been minimized.

@tmorehouse

tmorehouse added some commits Oct 24, 2017

@tmorehouse tmorehouse merged commit 4bdba0e into dev Oct 24, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the v4beta2/navbar-nav branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment