New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carousel): Minor adjustments to focusout/mouseout event handler #1239

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Oct 24, 2017

This fix keeps the carousel paused while focus (activeElement) remains inside the carousel container.

Addresses the second part of issue #1235

@tmorehouse tmorehouse added this to the v1.0.0 milestone Oct 24, 2017

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Oct 24, 2017

@tmorehouse tmorehouse changed the title from fix(carousel): Minor adjustments to fousout/mouseout event handler to fix(carousel): Minor adjustments to focusout/mouseout event handler Oct 24, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Oct 24, 2017

Codecov Report

Merging #1239 into dev will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1239   +/-   ##
====================================
  Coverage    33%     33%           
====================================
  Files       110     110           
  Lines      2881    2881           
  Branches    925     925           
====================================
  Hits        951     951           
  Misses     1550    1550           
  Partials    380     380
Impacted Files Coverage Δ
lib/components/carousel.vue 32.77% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40a5ee5...c0461bf. Read the comment docs.

@tmorehouse tmorehouse merged commit 330b70b into dev Oct 25, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse/carousel branch Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment