New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong relative path to package.json #1298

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
4 participants
@chanlito
Contributor

chanlito commented Nov 7, 2017

No description provided.

Bruce Hem
@codecov-io

This comment has been minimized.

codecov-io commented Nov 7, 2017

Codecov Report

Merging #1298 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1298   +/-   ##
=======================================
  Coverage   42.69%   42.69%           
=======================================
  Files         130      130           
  Lines        2621     2621           
  Branches      817      817           
=======================================
  Hits         1119     1119           
  Misses       1189     1189           
  Partials      313      313

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d36453...888e2c4. Read the comment docs.

@tmorehouse tmorehouse requested a review from pi0 Nov 7, 2017

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Nov 7, 2017

Hmm, this might not be pointing to the wrong file, but to a missing file (Nuxt modules usually have a local package.json file that describes the module)

@pi0 should this point to Bootstrap-Vue's package.json or to its own package.json?

@pi0

pi0 approved these changes Nov 7, 2017

Thanks!

@pi0 pi0 merged commit e766e75 into bootstrap-vue:dev Nov 7, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@chanlito

This comment has been minimized.

Contributor

chanlito commented Nov 7, 2017

Please help publish an npm patch for this, It'd be helpful for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment