New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-file): control size not supported in BS V4 #1305

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Nov 7, 2017

Bootstrap currently does not support the form-control-size on form-file input.

Removing both the mixin and the and the class reference.

@tmorehouse tmorehouse added this to the v1.0.0 milestone Nov 7, 2017

@tmorehouse tmorehouse requested review from pi0 and mosinve Nov 7, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Nov 7, 2017

Codecov Report

Merging #1305 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1305   +/-   ##
=======================================
  Coverage   42.69%   42.69%           
=======================================
  Files         130      130           
  Lines        2621     2621           
  Branches      817      817           
=======================================
  Hits         1119     1119           
  Misses       1189     1189           
  Partials      313      313
Impacted Files Coverage Δ
src/components/form-file/form-file.vue 8.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed953c...58c54d4. Read the comment docs.

@pi0

This comment has been minimized.

Member

pi0 commented Nov 7, 2017

LGTM. Please merge your self if is working :)

@tmorehouse tmorehouse merged commit e9a26cf into dev Nov 7, 2017

1 of 2 checks passed

License Compliance FOSSA analyzing commit
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse/form-file branch Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment