New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(alert): convert template to render function #1308

Merged
merged 3 commits into from Nov 10, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Nov 7, 2017

Convert alert.vue to alert.js and replace template with render function

tmorehouse added some commits Nov 7, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Nov 7, 2017

Codecov Report

Merging #1308 into dev will decrease coverage by 0.02%.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1308      +/-   ##
==========================================
- Coverage   42.69%   42.67%   -0.03%     
==========================================
  Files         130      130              
  Lines        2621     2620       -1     
  Branches      817      819       +2     
==========================================
- Hits         1119     1118       -1     
  Misses       1189     1189              
  Partials      313      313
Impacted Files Coverage Δ
src/components/alert/alert.js 96.96% <96.96%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acec621...17fef6b. Read the comment docs.

@tmorehouse tmorehouse requested a review from mosinve Nov 7, 2017

@mosinve

mosinve approved these changes Nov 8, 2017

@tmorehouse tmorehouse merged commit 8b0c7cd into dev Nov 10, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the renderfn/alert branch Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment