New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(dropdowns): convert templates to render functions #1314

Merged
merged 6 commits into from Nov 10, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Nov 8, 2017

No description provided.

tmorehouse added some commits Nov 8, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Nov 8, 2017

Codecov Report

Merging #1314 into dev will decrease coverage by 0.3%.
The diff coverage is 21.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1314      +/-   ##
==========================================
- Coverage   42.69%   42.39%   -0.31%     
==========================================
  Files         130      130              
  Lines        2621     2635      +14     
  Branches      817      819       +2     
==========================================
- Hits         1119     1117       -2     
- Misses       1189     1199      +10     
- Partials      313      319       +6
Impacted Files Coverage Δ
src/components/nav/index.js 100% <ø> (ø) ⬆️
src/components/dropdown/dropdown.js 100% <100%> (ø)
src/mixins/dropdown.js 5.04% <6.66%> (-0.79%) ⬇️
src/components/nav/nav-item-dropdown.js 66.66% <66.66%> (ø)
src/components/dropdown/dropdown.vue

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acec621...9ee767c. Read the comment docs.

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Nov 8, 2017

@mosinve

mosinve approved these changes Nov 8, 2017

@tmorehouse tmorehouse merged commit 3168e93 into dev Nov 10, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the renderfn/dropdowns branch Nov 10, 2017

@tmorehouse tmorehouse restored the renderfn/dropdowns branch Nov 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment