New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(button-toolbar): convert template to render function #1315

Merged
merged 2 commits into from Nov 10, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Nov 8, 2017

No description provided.

tmorehouse added some commits Nov 8, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Nov 8, 2017

Codecov Report

Merging #1315 into dev will decrease coverage by 0.17%.
The diff coverage is 2.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1315      +/-   ##
==========================================
- Coverage   42.69%   42.51%   -0.18%     
==========================================
  Files         130      130              
  Lines        2621     2627       +6     
  Branches      817      819       +2     
==========================================
- Hits         1119     1117       -2     
+ Misses       1189     1184       -5     
- Partials      313      326      +13
Impacted Files Coverage Δ
src/components/button-toolbar/button-toolbar.js 2.12% <2.12%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685de64...3927c46. Read the comment docs.

@mosinve

mosinve approved these changes Nov 8, 2017

@tmorehouse tmorehouse merged commit 765bfe3 into dev Nov 10, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the renderfn/button-toolbar branch Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment