New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-group): correct input-group right addon via prop #1317

Merged
merged 1 commit into from Nov 8, 2017

Conversation

Projects
None yet
3 participants
@williammck
Contributor

williammck commented Nov 8, 2017

Found this issue on >=1.0.0, appeared in commit bd4c3c3.

@codecov-io

This comment has been minimized.

codecov-io commented Nov 8, 2017

Codecov Report

Merging #1317 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1317   +/-   ##
=======================================
  Coverage   42.69%   42.69%           
=======================================
  Files         130      130           
  Lines        2621     2621           
  Branches      817      817           
=======================================
  Hits         1119     1119           
  Misses       1189     1189           
  Partials      313      313
Impacted Files Coverage Δ
src/components/input-group/input-group.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685de64...378c1a1. Read the comment docs.

@tmorehouse tmorehouse changed the title from Don't show right input-group addon if left prop is set to fix(input-group): correct input-group right addon via prop Nov 8, 2017

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Nov 8, 2017

Thanks!

@tmorehouse tmorehouse merged commit 061abc5 into bootstrap-vue:dev Nov 8, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment