New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover+tooltip): content not restored after hiding all popover with 'bv::hide::popover' #1323

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Nov 9, 2017

Prevents popovers/tooltip from showing empty content when re-opened after emitting bv::hide::popover/tooltip

Issue affected both popovers and tooltips

Closes issue: #1322

fix(popover+tooltip): body/content removed after hiding all popovers …
…with 'bv::hide::popover'

Prevents popovers/tooltip from showing empty content when re-opened after emitting `bv::hide::popover/tooltip`

Closes issue: #1322
@codecov-io

This comment has been minimized.

codecov-io commented Nov 9, 2017

Codecov Report

Merging #1323 into dev will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1323   +/-   ##
=======================================
  Coverage   42.69%   42.69%           
=======================================
  Files         130      130           
  Lines        2621     2621           
  Branches      817      817           
=======================================
  Hits         1119     1119           
  Misses       1189     1189           
  Partials      313      313
Impacted Files Coverage Δ
src/utils/tooltip.class.js 13.33% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4129fd3...e7d979e. Read the comment docs.

@tmorehouse tmorehouse requested a review from pi0 Nov 9, 2017

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Nov 9, 2017

Test markup:

<template>
  <div>
    <b-button id="a">button</b-button>
    <b-button id="b">button</b-button>
    <b-button id="c">button</b-button>
    <b-button id="d">hide others</b-button><br><br>
    <b-tooltip target="a" triggers="click" placement="top">Hello</b-tooltip>
    <b-tooltip target="b" triggers="click" placement="top">Hello</b-tooltip>
    <b-tooltip target="c" triggers="click" placement="top">Hello</b-tooltip>
    <b-tooltip target="d" triggers="click" placement="top" @show="onShow">Hello</b-tooltip> 
  </div>
</template>
<script>
  export default {
    methods: {
      onShow() {
        this.$root.$emit('bv::hide::tooltip')
      }
    }
  }
</script>

@tmorehouse tmorehouse changed the title from fix(popover+tooltip): body/content removed after hiding all popover with 'bv::hide::popover' to fix(popover+tooltip): content not restored after hiding all popover with 'bv::hide::popover' Nov 9, 2017

@tmorehouse tmorehouse merged commit 94488c6 into dev Nov 9, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the fix/1322 branch Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment