New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(form-select): convert template to render function #1333

Merged
merged 2 commits into from Nov 13, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Nov 11, 2017

No description provided.

tmorehouse added some commits Nov 11, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Nov 11, 2017

Codecov Report

Merging #1333 into dev will decrease coverage by 0.11%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1333      +/-   ##
==========================================
- Coverage   41.56%   41.45%   -0.12%     
==========================================
  Files         130      130              
  Lines        2656     2661       +5     
  Branches      828      829       +1     
==========================================
- Hits         1104     1103       -1     
- Misses       1207     1211       +4     
- Partials      345      347       +2
Impacted Files Coverage Δ
src/components/form-select/form-select.js 50% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45f550...ab14348. Read the comment docs.

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Nov 11, 2017

@tmorehouse tmorehouse merged commit 9adfc12 into dev Nov 13, 2017

1 of 2 checks passed

License Compliance FOSSA analyzing commit
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the renderfn/form-select branch Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment