New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): caption positioning prop #1341

Merged
merged 3 commits into from Nov 14, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Nov 13, 2017

Adds a Boolean prop caption-top, which when set will move the caption to the top of the table

tmorehouse added some commits Nov 13, 2017

[table] add caption-top prop
Boolean prop to move caption to top of table
@codecov-io

This comment has been minimized.

codecov-io commented Nov 13, 2017

Codecov Report

Merging #1341 into dev will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1341      +/-   ##
==========================================
- Coverage   41.94%   41.92%   -0.02%     
==========================================
  Files         130      130              
  Lines        2742     2743       +1     
  Branches      851      852       +1     
==========================================
  Hits         1150     1150              
- Misses       1208     1209       +1     
  Partials      384      384
Impacted Files Coverage Δ
src/components/table/table.vue 70.96% <0%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b811695...e0000a9. Read the comment docs.

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Nov 13, 2017

@tmorehouse tmorehouse merged commit 7c86e66 into dev Nov 14, 2017

1 of 2 checks passed

License Compliance FOSSA analyzing commit
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the table/caption branch Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment