New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(pagination+pagination-nav): convert templates to render function #1348

Merged
merged 4 commits into from Nov 15, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Nov 14, 2017

Also placed optimized common render function to mixin for code footprint efficiency

@codecov-io

This comment has been minimized.

codecov-io commented Nov 14, 2017

Codecov Report

Merging #1348 into dev will increase coverage by 0.09%.
The diff coverage is 41.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1348      +/-   ##
==========================================
+ Coverage   41.88%   41.97%   +0.09%     
==========================================
  Files         130      130              
  Lines        2741     2768      +27     
  Branches      852      861       +9     
==========================================
+ Hits         1148     1162      +14     
- Misses       1209     1216       +7     
- Partials      384      390       +6
Impacted Files Coverage Δ
src/components/pagination/pagination.vue 40% <30%> (+15%) ⬆️
src/mixins/pagination.js 51% <36%> (-5%) ⬇️
src/components/pagination-nav/pagination-nav.vue 78.26% <83.33%> (+2.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0ae3e...0055022. Read the comment docs.

@tmorehouse tmorehouse changed the title from perf(pagination-nav): convert template to render function to perf(pagination+pagination-nav): convert templates to render function Nov 15, 2017

tmorehouse added some commits Nov 15, 2017

@tmorehouse tmorehouse removed the Status: WIP label Nov 15, 2017

@tmorehouse tmorehouse merged commit e04291f into dev Nov 15, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the renderfn/pagination-nav branch Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment