New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-file): Use `label` as wrapper element + namespaced custom CSS #1353

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Nov 15, 2017

The original Microsoft Edge bug that affected for inputs wrapped in a label element has been fixed as of May 2017. https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8282613/

So we can revert back to using the <label> element as the wrapper for the custom file input. Using label provides for better semantic markup and accessibility.

This PR also name-spaces the Bootstrap-Vue custom custom-file CSS to negate the need for scoped CSS.

fix(form-file): Use `label` as wrapper element + namespaced custom CSS
The original Microsoft Edge bug that affected for inputs wrapped in a label element has been fixed as of May 2017. https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8282613/

So we can revert back to using the `<label>` element as the wrapper for the custom file input.

This PR also name-spaces the Bootstrap-Vue custom `custom-file` CSS to negate the need for scoped CSS.
@codecov-io

This comment has been minimized.

codecov-io commented Nov 15, 2017

Codecov Report

Merging #1353 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1353   +/-   ##
=======================================
  Coverage   43.12%   43.12%           
=======================================
  Files         130      130           
  Lines        2859     2859           
  Branches      889      889           
=======================================
  Hits         1233     1233           
  Misses       1236     1236           
  Partials      390      390
Impacted Files Coverage Δ
src/components/form-file/form-file.vue 20% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a1ef4f...9231b73. Read the comment docs.

@tmorehouse tmorehouse merged commit e2bc891 into dev Nov 15, 2017

1 of 2 checks passed

License Compliance FOSSA analyzing commit
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the form-file/label branch Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment