New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-group): add valid feedback support #1360

Merged
merged 25 commits into from Nov 18, 2017

Conversation

Projects
None yet
1 participant
@tmorehouse
Member

tmorehouse commented Nov 18, 2017

Include the valid-feedback option in b-form-group

Renamed b-form-feedback as b-form-invalid-feedback (aliased as b-form-feedback for backwards comparability), and created the new b-form-valid-feedback component.

Adds a new prop and slot valid-feedback to b-form-group

Reference: twbs/bootstrap#24811

tmorehouse added some commits Nov 18, 2017

feat(form-feedback): alias form-invalid-feedback
In preparation for the valid-feedback class
@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Nov 18, 2017

should the prop and slot feedback be renamed as invalid-feedback? (with fallback to deprecated feedback)

tmorehouse added some commits Nov 18, 2017

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Nov 18, 2017

Strangely, this builds & tests fine locally, but on CircleCI it barfs.

tmorehouse added some commits Nov 18, 2017

tmorehouse added some commits Nov 18, 2017

@tmorehouse tmorehouse merged commit 7f3535b into dev Nov 18, 2017

0 of 2 checks passed

ci/circleci Your tests failed on CircleCI
Details
License Compliance FOSSA analyzing commit
Details

@tmorehouse tmorehouse deleted the form/feedback branch Nov 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment