New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-file): invalid/valid feedback display for plain file input missing in Bootstrap V4 #1373

Merged
merged 2 commits into from Nov 20, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Nov 20, 2017

Bootstrap V4.beta.2 is missing the styles to display invalid and valid feedback for plain form-control-file inputs.

twbs/bootstrap#24831

Interim fix until addressed in Bootstrap V4 next release

tmorehouse added some commits Nov 20, 2017

fix(form-file): invalid/valid feedbcack display for plain file input
Bootstrap V4.beta.2 is missing the styles to display invalid and valid feedback for plain `form-control-file` inputs.

twbs/bootstrap#24831

@tmorehouse tmorehouse changed the title from fix(form-file): invalid/valid feedbcack display for plain file input to fix(form-file): invalid/valid feedback display for plain file input Nov 20, 2017

@tmorehouse tmorehouse changed the title from fix(form-file): invalid/valid feedback display for plain file input to fix(form-file): invalid/valid feedback display for plain file input missing in Bootstrap V4 Nov 20, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Nov 20, 2017

Codecov Report

Merging #1373 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1373   +/-   ##
=======================================
  Coverage   43.18%   43.18%           
=======================================
  Files         130      130           
  Lines        2867     2867           
  Branches      884      884           
=======================================
  Hits         1238     1238           
  Misses       1244     1244           
  Partials      385      385
Impacted Files Coverage Δ
src/components/form-file/form-file.vue 20% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b3ba32...e690ef9. Read the comment docs.

@tmorehouse tmorehouse merged commit 85ab0d0 into dev Nov 20, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the fix/form-file branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment