New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pagination+pagination-nav): disabled styling now works in BS V4.beta.2 #1381

Merged
merged 2 commits into from Nov 20, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Nov 20, 2017

Removing custom style for disabled pagination links, as it is now working in native bootstrap V4.beta.2 CSS

Custom focus styling is still needed for the active page link.

Also updated script code style to match current code style guidelines.

feat(pagination): disabled styling now works in BS V4.beta.2
Removing custom style for disabled links as it is now working in native bootstrap  V4.beta.2 CSS
@codecov-io

This comment has been minimized.

codecov-io commented Nov 20, 2017

Codecov Report

Merging #1381 into dev will not change coverage.
The diff coverage is 58.53%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1381   +/-   ##
=======================================
  Coverage   43.18%   43.18%           
=======================================
  Files         130      130           
  Lines        2867     2867           
  Branches      885      885           
=======================================
  Hits         1238     1238           
  Misses       1244     1244           
  Partials      385      385
Impacted Files Coverage Δ
src/components/pagination/pagination.vue 40% <36.84%> (ø) ⬆️
src/components/pagination-nav/pagination-nav.vue 78.26% <77.27%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ba693...515c40a. Read the comment docs.

@tmorehouse tmorehouse changed the title from feat(pagination): disabled styling now works in BS V4.beta.2 to feat(pagination+pagination-nav): disabled styling now works in BS V4.beta.2 Nov 20, 2017

@tmorehouse tmorehouse merged commit d51349f into dev Nov 20, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the fix/pagination branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment