New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): add no-body prop to b-tab #1385

Merged
merged 5 commits into from Nov 22, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Nov 21, 2017

When b-tabs are set to card mode, b-tab automatically adds the class card-body to itself.

This option allows the card-body class to not be added to the particular b-tab. Handy when using b-tabs to show images when in card mode.

tmorehouse added some commits Nov 21, 2017

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Nov 21, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Nov 21, 2017

Codecov Report

Merging #1385 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1385   +/-   ##
=======================================
  Coverage   43.12%   43.12%           
=======================================
  Files         130      130           
  Lines        2887     2887           
  Branches      892      891    -1     
=======================================
  Hits         1245     1245           
  Misses       1254     1254           
  Partials      388      388
Impacted Files Coverage Δ
src/components/tabs/tab.js 81.81% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bfadf1...d081ea7. Read the comment docs.

tmorehouse added some commits Nov 21, 2017

`<b-tabs>`. Note that you should add `no-body` prop on `<b-card>` element in order
to propertly decorate the card header and remove the extra padding introduced
by `card-body`.
`<b-tabs>`. and plce it inside a `<b-card>` component. Note that you should add

This comment has been minimized.

@jackmu95

jackmu95 Nov 21, 2017

Contributor

Typo: "plce" -> "place"

This comment has been minimized.

@tmorehouse

tmorehouse Nov 21, 2017

Member

Thanks!

@tmorehouse tmorehouse merged commit ef3ff06 into dev Nov 22, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the feat/tabs branch Nov 22, 2017

pi0 added a commit that referenced this pull request Nov 29, 2017

feat(tabs): add no-body prop to b-tab (#1385)
* Update tab.js

* document b-tab no-body prop

* Update README.md

* Update README.md

* typo fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment