New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): allow custom size classes to be passed to the size prop #1389

Merged
merged 2 commits into from Nov 22, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Nov 21, 2017

Removed the validator for the size prop, so that people can use custom .btn-{size} classes

fix(button): allow custom size classes to be passed to the size prop
Removed the validator for the size prop, so that people can use custom `.btn-{size}` classes
remove import of arrayIncludes
no longer needed with removal of validator
@codecov-io

This comment has been minimized.

codecov-io commented Nov 21, 2017

Codecov Report

Merging #1389 into dev will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1389      +/-   ##
==========================================
- Coverage   42.95%   42.93%   -0.02%     
==========================================
  Files         130      130              
  Lines        2873     2872       -1     
  Branches      889      889              
==========================================
- Hits         1234     1233       -1     
  Misses       1249     1249              
  Partials      390      390
Impacted Files Coverage Δ
src/components/button/button.js 72.72% <ø> (-1.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51ef9e3...7c807c5. Read the comment docs.

@tmorehouse tmorehouse merged commit 96fb934 into dev Nov 22, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the fix/button branch Nov 22, 2017

pi0 added a commit that referenced this pull request Nov 29, 2017

fix(button): allow custom size classes to be passed to the size prop (#…
…1389)

* fix(button): allow custom size classes to be passed to the size prop

Removed the validator for the size prop, so that people can use custom `.btn-{size}` classes

* remove import of arrayIncludes

no longer needed with removal of validator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment