New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): add toggleDetails method to scoped item slots #1404

Merged
merged 8 commits into from Nov 25, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Nov 24, 2017

Adds a function reference to the row's field scope variable for toggling the display of the row details scoped slot. Uses the $set method to ensure reactivity, and negate the need to pre-define _showDetails property in the item record for reactivity.

@codecov-io

This comment has been minimized.

codecov-io commented Nov 24, 2017

Codecov Report

Merging #1404 into dev will decrease coverage by <.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1404      +/-   ##
==========================================
- Coverage   42.46%   42.45%   -0.01%     
==========================================
  Files         130      130              
  Lines        2918     2923       +5     
  Branches      903      906       +3     
==========================================
+ Hits         1239     1241       +2     
- Misses       1278     1281       +3     
  Partials      401      401
Impacted Files Coverage Δ
src/components/table/table.vue 72.61% <77.77%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6176be6...09f3ab0. Read the comment docs.

@tmorehouse tmorehouse changed the title from [WIP] feat(table): add toggelDetails method to scoped item slots to feat(table): add toggleDetails method to scoped item slots Nov 24, 2017

@tmorehouse tmorehouse removed the Status: WIP label Nov 24, 2017

@tmorehouse tmorehouse requested review from pi0 and mosinve Nov 24, 2017

mosinve and others added some commits Nov 24, 2017

@tmorehouse tmorehouse merged commit a9c4b7d into dev Nov 25, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the table/details branch Nov 25, 2017

pi0 added a commit that referenced this pull request Nov 29, 2017

feat(table): add toggleDetails method to scoped item slots (#1404)
* feat(table): add toggelDetails method to scoped item slots

* add toggleDetails to details scoped var

* documentation update

* Update README.md

* Update README.md

* Update README.md

* Use idMixin and add aria-describedby for details

* ESlint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment