New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SFC transpilation in es buld for IE11 #1410

Merged
merged 16 commits into from Nov 27, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Nov 27, 2017

More script from .vue file to external .js file to allow babel transpile in /es

table.vue is updated in the table/stacked branch

Fixes issue #1409

tmorehouse added some commits Nov 27, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Nov 27, 2017

Codecov Report

Merging #1410 into dev will decrease coverage by 0.79%.
The diff coverage is 25.07%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #1410     +/-   ##
=========================================
- Coverage   42.45%   41.66%   -0.8%     
=========================================
  Files         130      135      +5     
  Lines        2923     2825     -98     
  Branches      907      872     -35     
=========================================
- Hits         1241     1177     -64     
+ Misses       1281     1189     -92     
- Partials      401      459     +58
Impacted Files Coverage Δ
src/components/form-file/_form-file.js 10.25% <10.25%> (ø)
src/components/form-input/form-input.vue 100% <100%> (+51.42%) ⬆️
src/components/form-group/form-group.vue 100% <100%> (+24.52%) ⬆️
src/components/progress/_progress.js 100% <100%> (ø)
src/components/modal/modal.vue 100% <100%> (+73.19%) ⬆️
src/components/progress/progress.vue 100% <100%> (ø) ⬆️
src/components/form-file/form-file.vue 100% <100%> (+80%) ⬆️
src/components/modal/_modal.js 16.57% <16.57%> (ø)
src/components/form-input/_form-input.js 36% <36%> (ø)
src/components/form-group/_form-group.js 75.75% <75.75%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6c7d8...8952b28. Read the comment docs.

tmorehouse added some commits Nov 27, 2017

@tmorehouse tmorehouse requested a review from pi0 Nov 27, 2017

@tmorehouse tmorehouse changed the title from [WIP] fix: es builds to fix: SFC transpilation in es buld Nov 27, 2017

@tmorehouse tmorehouse removed the Status: WIP label Nov 27, 2017

@tmorehouse tmorehouse merged commit ce80809 into dev Nov 27, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the fix/es branch Nov 27, 2017

@tmorehouse tmorehouse changed the title from fix: SFC transpilation in es buld to fix: SFC transpilation in es buld for IE11 Nov 27, 2017

pi0 added a commit that referenced this pull request Nov 29, 2017

fix: SFC transpilation in es buld (#1410)
* Create _form-file.js

* ESLint

* Update form-file.vue

* ESLint

* Create _form-group.js

* Update form-group.vue

* ESLint

* Create _form-input.js

* Update form-input.vue

* ESLint

* ESLint

* Create _progress.js

* Update progress.vue

* Create _modal.js

* Update modal.vue

* ESLint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment