New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-group): new prop for label-class, deprecate prop feedback in favor of invalid-feedback #1412

Merged
merged 4 commits into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Nov 28, 2017

Adds a new prop label-class which allows the user to apply additional classes to the label (i.e. responsive padding or alignment classes)

@codecov-io

This comment has been minimized.

codecov-io commented Nov 28, 2017

Codecov Report

Merging #1412 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1412   +/-   ##
=======================================
  Coverage   40.67%   40.67%           
=======================================
  Files         136      136           
  Lines        2778     2778           
  Branches      854      854           
=======================================
  Hits         1130     1130           
  Misses       1164     1164           
  Partials      484      484
Impacted Files Coverage Δ
src/components/form-group/_form-group.js 75.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f7eba1...0574325. Read the comment docs.

tmorehouse added some commits Nov 28, 2017

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Nov 28, 2017

Also deprecated the prop feedback in favor of invalid-feedback (to align with the valid-feedback prop, and updated docs to use the new prop

@tmorehouse tmorehouse changed the title from feat(form-group): add prop for label-class to feat(form-group): new prop for label-class, deprecate prop feedback in favor of invalid-feedback Nov 28, 2017

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Nov 28, 2017

@tmorehouse tmorehouse merged commit 7d61cb4 into dev Nov 28, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the feat/form-group branch Nov 28, 2017

pi0 added a commit that referenced this pull request Nov 29, 2017

feat(form-group): new prop for label-class, deprecate prop feedback i…
…n favor of invalid-feedback (#1412)

* feat(form-group): add prop for label-class

* Update README.md

* Update README.md

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment