New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-group): set aria-describedby attribute on input if label-for provided #1431

Merged
merged 6 commits into from Dec 6, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Dec 6, 2017

Helps ensure that all screen readers associate the feedback and description to the input, when label-for is set.

Preserves any original aria-describedby attributes that may be present on the input.

tmorehouse added some commits Dec 6, 2017

fet(form-group): add aria-describedby on input if label-for set
Helps ensure that all screen readers associate the feedback and description to the input, when label-for is set.

Preserves any original aria-describedby attributes that may be present on the input.
@codecov-io

This comment has been minimized.

codecov-io commented Dec 6, 2017

Codecov Report

Merging #1431 into dev will decrease coverage by 0.08%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1431      +/-   ##
==========================================
- Coverage   40.81%   40.73%   -0.09%     
==========================================
  Files         135      135              
  Lines        2803     2816      +13     
  Branches      871      876       +5     
==========================================
+ Hits         1144     1147       +3     
- Misses       1172     1178       +6     
- Partials      487      491       +4
Impacted Files Coverage Δ
src/components/form-group/form-group.js 63.49% <23.07%> (-10.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa45d3e...836bf0e. Read the comment docs.

tmorehouse added some commits Dec 6, 2017

@tmorehouse tmorehouse changed the title from fet(form-group): add aria-describedby on input if label-for set to fet(form-group): set aria-describedby attribute on input if label-for provided Dec 6, 2017

@tmorehouse tmorehouse changed the title from fet(form-group): set aria-describedby attribute on input if label-for provided to feat(form-group): set aria-describedby attribute on input if label-for provided Dec 6, 2017

@tmorehouse tmorehouse requested a review from pi0 Dec 6, 2017

@tmorehouse tmorehouse merged commit 6bd12bb into dev Dec 6, 2017

1 of 2 checks passed

License Compliance FOSSA analyzing commit
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the feat/form-group branch Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment