New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: evalute slots() once in functional component render functions #1438

Merged
merged 4 commits into from Dec 8, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Dec 7, 2017

Addresses issue #1437

@codecov-io

This comment has been minimized.

codecov-io commented Dec 7, 2017

Codecov Report

Merging #1438 into dev will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1438      +/-   ##
==========================================
+ Coverage   40.73%   40.81%   +0.08%     
==========================================
  Files         135      135              
  Lines        2816     2820       +4     
  Branches      876      876              
==========================================
+ Hits         1147     1151       +4     
  Misses       1178     1178              
  Partials      491      491
Impacted Files Coverage Δ
src/components/media/media.js 100% <100%> (ø) ⬆️
src/components/card/card.js 94.11% <100%> (+0.36%) ⬆️
src/components/jumbotron/jumbotron.js 100% <100%> (ø) ⬆️
src/components/input-group/input-group.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39eb237...8113812. Read the comment docs.

tmorehouse added some commits Dec 7, 2017

@tmorehouse tmorehouse removed the Status: WIP label Dec 7, 2017

@tmorehouse tmorehouse requested review from pi0 and alexsasharegan Dec 7, 2017

@alexsasharegan

I never thought to do this before! Not a bad idea 👍

@tmorehouse tmorehouse merged commit 3c42477 into dev Dec 8, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the perf/slots branch Dec 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment