New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(list-group): disabled button items #1444
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1444 +/- ##
=======================================
Coverage 47.41% 47.41%
=======================================
Files 135 135
Lines 2529 2529
Branches 789 789
=======================================
Hits 1199 1199
Misses 950 950
Partials 380 380
Continue to review full report at Codecov.
|
I'm wondering if maybe we should add in a boolean Any thoughts on this @pi0 and @alexsasharegan ? |
@tmorehouse , that seems like a good idea. For links, is the component rendering based on the presence of an |
Yeah, It renders a But if the proposed new prop |
When `button` is true, no linkProps are applied, and the `tag` prop is ignored
When
tag
was set to'button'
and thedisabled
prop was also set, the rendered button was not being disabled (although it had the disabled class and appeared disabled). This fix ensures the disabled attribute is set when rendered as a button and the disabled prop is true.Adds new prop
button
, as a shortcut, to force render as abutton
list-group-item-actionAlso extends the documentation with additional examples