New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carousel): remove un-needed `aria-` atribute on slides #1448

Merged
merged 4 commits into from Dec 11, 2017

Conversation

Projects
None yet
1 participant
@tmorehouse
Member

tmorehouse commented Dec 11, 2017

No description provided.

@codecov

This comment has been minimized.

codecov bot commented Dec 11, 2017

Codecov Report

Merging #1448 into dev will increase coverage by 0.5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #1448     +/-   ##
=========================================
+ Coverage   47.41%   47.92%   +0.5%     
=========================================
  Files         135      135             
  Lines        2529     2500     -29     
  Branches      789      785      -4     
=========================================
- Hits         1199     1198      -1     
+ Misses        950      926     -24     
+ Partials      380      376      -4
Impacted Files Coverage Δ
src/components/carousel/carousel.js 32.38% <ø> (+6.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9bddbd...49b2c17. Read the comment docs.

tmorehouse added some commits Dec 11, 2017

@tmorehouse tmorehouse referenced this pull request Dec 11, 2017

Closed

BS4/Bootstrap-Vue Accessibility recommendations #333

32 of 33 tasks complete

@tmorehouse tmorehouse merged commit 260919f into dev Dec 11, 2017

4 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing a9bddbd...49b2c17
Details
codecov/project 47.92% (+0.5%) compared to a9bddbd
Details

@tmorehouse tmorehouse deleted the fix/carousel branch Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment