New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip+popover): append to `.modal-content` instead of `.modal` #1465

Merged
merged 1 commit into from Dec 14, 2017

Conversation

Projects
None yet
1 participant
@tmorehouse
Member

tmorehouse commented Dec 14, 2017

Ensures that interactive popovers (i.e. with input(s)) are inside the enforce focus tab ring cycle

Fixes #1464

fix(tooltip+popover): append to `.modal-content` instead of `.modal`
Ensures that interactive popovers  (i.e. with input(s)) are inside the enforce focus tab ring cycle

Fixes #1464
@codecov

This comment has been minimized.

codecov bot commented Dec 14, 2017

Codecov Report

Merging #1465 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1465   +/-   ##
=======================================
  Coverage   53.11%   53.11%           
=======================================
  Files         134      134           
  Lines        2197     2197           
  Branches      701      701           
=======================================
  Hits         1167     1167           
  Misses        731      731           
  Partials      299      299
Impacted Files Coverage Δ
src/utils/tooltip.class.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc67a2d...b6f4d60. Read the comment docs.

@tmorehouse tmorehouse merged commit b53715c into dev Dec 14, 2017

4 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 53.11%)
Details
codecov/project 53.11% (+0%) compared to bc67a2d
Details

@tmorehouse tmorehouse deleted the fix/popovermodal branch Dec 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment